Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a job to renew user subscriptions #82

Merged
merged 4 commits into from
Apr 16, 2020
Merged

Added a job to renew user subscriptions #82

merged 4 commits into from
Apr 16, 2020

Conversation

levb
Copy link
Contributor

@levb levb commented Apr 11, 2020

Summary

  • Added a simple job to renew all user subscriptions every 24 hours
  • Increased the default subscription expiry to 48 hours

Ticket Link

Fixes #54

@levb levb added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Apr 11, 2020
@levb levb added this to the 0.1.0 milestone Apr 11, 2020
mickmister
mickmister previously approved these changes Apr 12, 2020
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 just one comment suggestion

server/jobs/renew_job.go Outdated Show resolved Hide resolved
larkox
larkox previously approved these changes Apr 13, 2020
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment.

server/jobs/job_manager.go Show resolved Hide resolved
Co-Authored-By: Michael Kochell <6913320+mickmister@users.noreply.github.com>
@levb levb dismissed stale reviews from larkox and mickmister via 2aebbc8 April 13, 2020 08:26
@levb levb removed the 2: Dev Review Requires review by a core committer label Apr 13, 2020
@codecov-io
Copy link

codecov-io commented Apr 13, 2020

Codecov Report

Merging #82 into master will decrease coverage by 0.31%.
The diff coverage is 4.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   28.20%   27.89%   -0.32%     
==========================================
  Files          57       58       +1     
  Lines        2053     2076      +23     
==========================================
  Hits          579      579              
- Misses       1409     1432      +23     
  Partials       65       65              
Impacted Files Coverage Δ
server/command/subscribe.go 0.00% <0.00%> (ø)
server/jobs/renew_job.go 0.00% <0.00%> (ø)
server/mscalendar/subscription.go 0.00% <0.00%> (ø)
server/remote/msgraph/subscription.go 0.00% <ø> (ø)
server/jobs/job_manager.go 77.41% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c7153...76c0c59. Read the comment docs.

@mickmister
Copy link
Contributor

/update-branch

@DHaussermann DHaussermann requested a review from larkox April 16, 2020 18:44
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke with @mickmister We want to merge this now to be verified in master. This will aid in making other PRs more testable.

@DHaussermann DHaussermann removed the 3: QA Review Requires review by a QA tester label Apr 16, 2020
@mickmister mickmister merged commit efb81d5 into mattermost:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renew event subscriptions periodically
6 participants