Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification processor fixes #81

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Notification processor fixes #81

merged 3 commits into from
Apr 16, 2020

Conversation

levb
Copy link
Contributor

@levb levb commented Apr 11, 2020

Summary

Fixed notification queue size limiting - was my own ignorant code before.

Ticket Link

None

@levb levb added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Apr 11, 2020
@levb levb added this to the 0.1.0 milestone Apr 11, 2020
@levb levb requested review from larkox and mickmister April 11, 2020 08:10
mickmister
mickmister approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

larkox
larkox approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb removed the 2: Dev Review Requires review by a core committer label Apr 13, 2020
@levb levb requested a review from DHaussermann April 13, 2020 08:27
@levb
Copy link
Contributor Author

levb commented Apr 13, 2020

@DHaussermann this PR is not really testable in itself, and a trivial unit test is provided.

@codecov-io
Copy link

codecov-io commented Apr 13, 2020 •
edited
Loading

Codecov Report

Merging #81 into master will increase coverage by 0.39%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   27.80%   28.20%   +0.39%     
==========================================
  Files          57       57              
  Lines        2057     2053       -4     
==========================================
+ Hits          572      579       +7     
+ Misses       1420     1409      -11     
  Partials       65       65
Impacted Files Coverage Δ
server/mscalendar/notification.go 50.79% <60.00%> (+3.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd0a1f...59c0b1e. Read the comment docs.

DHaussermann
DHaussermann approved these changes Apr 16, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up @levb

I'm fine with this being merged. This can be tested as part of end 2 end tested in master.

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Apr 16, 2020
@mickmister mickmister merged commit a4c7153 into mattermost:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@mickmister mickmister mickmister approved these changes

@larkox larkox larkox approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@levb @codecov-io @larkox @mickmister @DHaussermann