-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dedicated Microsoft integration user #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment and one question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mickmister I started over with a fresh server and tested an install without a bot.
They produce the following error: All other slash commands seem to work fine. If this is related to a bot-less install, possibly there is an update needed to how permissions are configured. Thoughts? Also Please remove |
@DHaussermann I'm unable to reproduce the issues with |
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 25.31% 22.59% -2.72%
==========================================
Files 61 61
Lines 2303 2248 -55
==========================================
- Hits 583 508 -75
- Misses 1654 1682 +28
+ Partials 66 58 -8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed.
- Tested install without bot service user
- Ran through brief regression testing
- Issues found above were due to mis-configured Azure app permissions (Future doc change coming to clarify this) The issue where unrelated to bot removal.
- No other issues found
LGTM! Thanks @mickmister
Summary
This PR removes the bot account from the OAuth process. The application level permissions work the exact same way as before.
Calls to
GetSchedule
are now adjusted to one user's schedule, to have access to the user's event details.Ticket Link
Fixes #75