Change repo name to mattermost-plugin-mscalendar #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmister
added
2: Dev Review
mickmister
commented
Jan 6, 2020
| **`System Console` > `PLUGINS` > `MS Office Calendar`** | ||
|
|
||
| - [ ] (TODO: rename in plugin settings - currently `TODO:name`) | ||
| **`System Console` > `PLUGINS` > `Microsoft Calendar`** |
There was a problem hiding this comment.
README display name change
mickmister
commented
Jan 6, 2020
| "description": "TODO: description.", | ||
| "id": "com.mattermost.mscalendar", | ||
| "name": "Microsoft Calendar", | ||
| "description": "Microsoft Calendar Integration", |
There was a problem hiding this comment.
plugin.json display name changes
mickmister
commented
Jan 6, 2020
| CommandTrigger = "msoffice" | ||
| ApplicationName = "Microsoft Calendar" | ||
| Repository = "mattermost-plugin-mscalendar" | ||
| CommandTrigger = "mscalendar" |
There was a problem hiding this comment.
bot and command display name changes
There was a problem hiding this comment.
Suggest mscal for command? @aaronrothschild
There was a problem hiding this comment.
(can be a separate change though, not blocking for this PR)
levb
approved these changes
Jan 7, 2020
| CommandTrigger = "msoffice" | ||
| ApplicationName = "Microsoft Calendar" | ||
| Repository = "mattermost-plugin-mscalendar" | ||
| CommandTrigger = "mscalendar" |
There was a problem hiding this comment.
Suggest mscal for command? @aaronrothschild
| CommandTrigger = "msoffice" | ||
| ApplicationName = "Microsoft Calendar" | ||
| Repository = "mattermost-plugin-mscalendar" | ||
| CommandTrigger = "mscalendar" |
There was a problem hiding this comment.
(can be a separate change though, not blocking for this PR)
crspeller
approved these changes
Jan 7, 2020
mickmister
added
the
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames the repo from
*msofficeto*mscalendar, as the plugin is specific to Microsoft Calendar part of the Microsoft Office suite.Various display name changes in:
Ticket Link
https://mattermost.atlassian.net/browse/MM-21531