Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-103] Add event reminder subscriptions to settings panel #120

Merged
merged 7 commits into from
May 28, 2020
Merged

[GH-103] Add event reminder subscriptions to settings panel #120

merged 7 commits into from
May 28, 2020

Conversation

larkox
Copy link
Contributor

@larkox larkox commented May 6, 2020

Summary

Add event reminder subscriptions to settings panel

Ticket Link

Fix #103

@larkox larkox requested a review from mickmister as a code owner May 6, 2020 14:34
@larkox larkox requested a review from levb May 6, 2020 14:35
@larkox larkox added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 6, 2020
mickmister
mickmister suggested changes May 6, 2020
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mainly just a request to rename notification_setting to something more specific

server/mscalendar/settings_notifications.go Outdated Show resolved Hide resolved
server/mscalendar/settings_notifications.go Show resolved Hide resolved
server/mscalendar/settings_notifications.go Outdated Show resolved Hide resolved
server/mscalendar/settings_notifications.go Show resolved Hide resolved
server/mscalendar/settings_notifications.go
}

func (s *notificationSetting) IsDisabled(foreignValue interface{}) bool {
return foreignValue == "false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reference these as constants like BOOL_STRING_FALSE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am making in parallel some changes on how to handle slack attachment context, and therefore how to pass this value here. Long story short, marshaling and unmarshaling the values as jsons. You can see some of that implementation here.

I will leave this as it is, and change it in the future when those changes are in place.

@levb
Copy link
Contributor

levb commented May 6, 2020

(not removing the Dev Review yet for @mickmister's feedback)

@larkox
Change notification setting id name, getCalendar function name to get…
f169ab0 
…Cal, and return notification setting directly
@larkox larkox requested a review from mickmister May 12, 2020 09:25
mickmister
mickmister approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mickmister
Copy link
Contributor

/update-branch

@mickmister mickmister requested a review from DHaussermann May 13, 2020 02:06
@mickmister mickmister removed the 2: Dev Review Requires review by a core committer label May 13, 2020
@codecov-io
Copy link

Codecov Report

Merging #120 into master will decrease coverage by 0.71%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   24.67%   23.96%   -0.72%     
==========================================
  Files          65       66       +1     
  Lines        2545     2621      +76     
==========================================
  Hits          628      628              
- Misses       1841     1917      +76     
  Partials       76       76
Impacted Files Coverage Δ
server/mscalendar/settings.go 0.00% <0.00%> (ø)
server/mscalendar/settings_notifications.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0013cc5...7b02807. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020 •
edited
Loading

Codecov Report

Merging #120 into master will decrease coverage by 0.72%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   25.01%   24.29%   -0.73%     
==========================================
  Files          65       66       +1     
  Lines        2550     2626      +76     
==========================================
  Hits          638      638              
- Misses       1832     1908      +76     
  Partials       80       80
Impacted Files Coverage Δ
server/mscalendar/settings.go 0.00% <0.00%> (ø)
server/mscalendar/settings_notifications.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fbe2c8...cab8b47. Read the comment docs.

@DHaussermann
Copy link

Tested and passed

  • Confirmed that when no subscription is preset Yes will create one
  • Selecting No from the panel will delete the subscription
  • Briefly regression tested login work flow and working subscription
    LGTM!

@larkox note that I did see an issue here but, it was not related to the settings panel. Created #148 to address.

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels May 28, 2020
@larkox larkox merged commit 95ad6b1 into mattermost:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@mickmister mickmister mickmister approved these changes

@levb levb levb approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add event reminder subscriptions to settings panel
7 participants
@larkox @levb @mickmister @codecov-io @codecov-commenter @DHaussermann @mattermod