-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image for granting admin consent #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 24.09% 24.09%
=======================================
Files 64 64
Lines 2523 2523
=======================================
Hits 608 608
Misses 1839 1839
Partials 76 76 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mickmister This update makes the step more clear. This info solves a stumbling bloxk I've hit a couple times before with the setup.
LGTM!
/update-branch |
There is a final step after add permissions in the Azure portal, which is granting the application the permissions with an Azure admin account. This PR adds an image showing how to do so.
Here's the rendered version of the readme now /~https://github.com/mattermost/mattermost-plugin-mscalendar/blob/254e534aa98b7b654fe6c4e1d8972f28604b937f/README.md