Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image for granting admin consent #107

Merged
merged 3 commits into from
May 5, 2020

Conversation

mickmister
Copy link
Contributor

There is a final step after add permissions in the Azure portal, which is granting the application the permissions with an Azure admin account. This PR adds an image showing how to do so.

Here's the rendered version of the readme now /~https://github.com/mattermost/mattermost-plugin-mscalendar/blob/254e534aa98b7b654fe6c4e1d8972f28604b937f/README.md

@mickmister mickmister added 2: Dev Review Requires review by a core committer 1: PM Review Requires review by a product manager 3: QA Review Requires review by a QA tester labels Apr 27, 2020
@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label Apr 28, 2020
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb removed the 2: Dev Review Requires review by a core committer label Apr 29, 2020
@codecov-io
Copy link

codecov-io commented Apr 29, 2020

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   24.09%   24.09%           
=======================================
  Files          64       64           
  Lines        2523     2523           
=======================================
  Hits          608      608           
  Misses       1839     1839           
  Partials       76       76           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b1fee...2a02171. Read the comment docs.

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mickmister This update makes the step more clear. This info solves a stumbling bloxk I've hit a couple times before with the setup.
LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels May 4, 2020
@mickmister
Copy link
Contributor Author

/update-branch

@mickmister mickmister merged commit 3aa0ee7 into master May 5, 2020
@mickmister mickmister deleted the add-grant-permissions-to-docs branch May 5, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants