Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-517]: Fixed the issue 'Unable to subscribe to groups or subgroups #518

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Aug 20, 2024

Summary

  1. Added the condition that the permission to the project will only be checked if the subscription to be created is of project-level subscription.
  2. Permission for the group and sub-group is already getting checked in the ResolveNamespaceAndProject function.

Ticket Link

Fixes #517

Testing Steps

  1. Create a group, sub-group, and project subscriptions.

@Kshitij-Katiyar Kshitij-Katiyar changed the title [MM-517]: Fixed the issue #517 'Unable to subscribe to groups or subgroups [MM-517]: Fixed the issue 'Unable to subscribe to groups or subgroups Aug 20, 2024
@raghavaggarwal2308 raghavaggarwal2308 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 20, 2024
@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.10.0 milestone Nov 22, 2024
@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Nov 24, 2024
@arush-vashishtha
Copy link

@Kshitij-Katiyar I have found an issue while testing this PR, when we create subscriptions for subgroups or projects we are getting multiple events in the channel for the subscription. Please look into this issue.
image
image

@Kshitij-Katiyar
Copy link
Contributor Author

@Kshitij-Katiyar I have found an issue while testing this PR, when we create subscriptions for subgroups or projects we are getting multiple events in the channel for the subscription. Please look into this issue. image image

@arush-vashishtha This issue is not related to this PR, I would like you to log a new issue for this with all the proper reproduction steps.
The reason for this issue is an active webhook for any previously deleted subscription.
The same issue is reproducible in the Github plugin, please log the same issue there also.
If you don't see any other issue with this PR, we can merge it.

@arush-vashishtha
Copy link

@Kshitij-Katiyar I have found an issue while testing this PR, when we create subscriptions for subgroups or projects we are getting multiple events in the channel for the subscription. Please look into this issue. image image

@arush-vashishtha This issue is not related to this PR, I would like you to log a new issue for this with all the proper reproduction steps. The reason for this issue is an active webhook for any previously deleted subscription. The same issue is reproducible in the Github plugin, please log the same issue there also. If you don't see any other issue with this PR, we can merge it.

Sure, Everything else is working fine in this PR. I will log a new issue for this one.

@Kshitij-Katiyar Kshitij-Katiyar added QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Nov 29, 2024
@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed QA Review Done PR has been approved by QA labels Nov 29, 2024
@raghavaggarwal2308 raghavaggarwal2308 merged commit 87c2865 into master Nov 29, 2024
7 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-517 branch November 29, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.9.1] Unable to subscribe to groups or subgroups
4 participants