Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: support LockWithContext #35

Merged
merged 9 commits into from
Mar 12, 2020
Merged

cluster: support LockWithContext #35

merged 9 commits into from
Mar 12, 2020

Conversation

lieut-data
Copy link
Member

Summary

This branches off #33 to add support for locking with a context (and thus implicitly supporting lock cancellation, "try lock" semantics, etc.).

I opted not to merge directly to master given the rework happening in that active PR.

mickmister
mickmister approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request on function comment. Otherwise LGTM!

cluster/mutex.go Outdated Show resolved Hide resolved
@lieut-data @mickmister
Update cluster/mutex.go
edf3953 
Co-Authored-By: Michael Kochell <mjkochell@gmail.com>
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Mar 4, 2020
@lieut-data lieut-data mentioned this pull request Mar 6, 2020
Merged
@lieut-data
Copy link
Member Author

@ali-farooq0, is this something you can take a look at soon?

alifarooq0
alifarooq0 approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@alifarooq0 alifarooq0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alifarooq0 alifarooq0 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 11, 2020
@alifarooq0
Copy link
Contributor

/update-branch

@alifarooq0
Copy link
Contributor

alifarooq0 commented Mar 11, 2020 •
edited
Loading

oh, the magical command doesn't work here ;/ nvm looks like this is going into non-master so will leave as is.

@lieut-data lieut-data changed the base branch from cluster-user-space-key-expiry to master March 12, 2020 19:39
@lieut-data lieut-data merged commit e5a2c51 into master Mar 12, 2020
@hanzei hanzei deleted the lock-with-context branch March 12, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alifarooq0 alifarooq0 alifarooq0 approved these changes

@mickmister mickmister mickmister approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lieut-data @alifarooq0 @mickmister @hanzei