Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflow push tag triggers #353

Merged
merged 1 commit into from
Apr 26, 2023
Merged

fix: workflow push tag triggers #353

merged 1 commit into from
Apr 26, 2023

Conversation

fmartingr
Copy link
Contributor

Summary

According to Github documentation1, using v1.** triggers any v1.XXX tag, which means that the expression is not really a regex. I changed the push triggers to v** to ensure that it trigger on any new version tag.

Ticket Link

None

Release Note

none

Footnotes

  1. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-workflow-only-when-a-push-of-specific-tags-occurs

@fmartingr fmartingr added the 2: Dev Review Requires review by a developer label Apr 26, 2023
@fmartingr fmartingr self-assigned this Apr 26, 2023
@mm-cloud-bot mm-cloud-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 26, 2023
Copy link
Collaborator

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 👍

@fmartingr fmartingr merged commit 712080c into master Apr 26, 2023
@fmartingr fmartingr deleted the fix/tags-trigger branch April 26, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants