Include ready installations in reconcile limit check
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installations that are in the `ready` state are nearly done reconciling, but should be treated the same until they are stable. This change corrects an issue where the limiter logic for concurrent reconciliations treated the `ready` installations as if they weren't reconciling yet. This can lead to them not properly being prioritized to check when they are stable when reconciling many installations all at once.
gabrieljackson
added
2: Dev Review
mm-cloud-bot
added
release-note
mirshahriar
approved these changes
Feb 22, 2023
fmartingr
approved these changes
Feb 23, 2023
gabrieljackson
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installations that are in the
readystate are nearly done reconciling, but should be treated the same until they are stable. This change corrects an issue where the limiter logic for concurrent reconciliations treated thereadyinstallations as if they weren't reconciling yet. This can lead to them not properly being prioritized to check when they are stable when reconciling many installations all at once.Fixes https://mattermost.atlassian.net/browse/MM-50752