Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-49782] Allow configurable deployment revision history limit #335

Merged
merged 6 commits into from
Feb 1, 2023
Merged

[MM-49782] Allow configurable deployment revision history limit #335

merged 6 commits into from
Feb 1, 2023

Conversation

fmartingr
Copy link
Contributor

Summary

Allows for a configurable Deployment.spec.revisionHistoryLimit directly from the Mattermost spec.

Ticket Link

https://mattermost.atlassian.net/browse/MM-49782

Release Note

Allow configurable deployment revision history limit

@mm-cloud-bot mm-cloud-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 31, 2023
@fmartingr fmartingr self-assigned this Jan 31, 2023
@fmartingr fmartingr added 2: Dev Review Requires review by a developer and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 31, 2023
@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 31, 2023
mirshahriar
mirshahriar approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@mirshahriar mirshahriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just fixed minor typo

apis/mattermost/v1beta1/mattermost_types.go Outdated Show resolved Hide resolved
apis/mattermost/v1beta1/mattermost_types.go Outdated Show resolved Hide resolved
fmartingr and others added 3 commits February 1, 2023 07:23
@fmartingr @mirshahriar
Documentation typos
b523315 
Co-authored-by: Mir Shahriar Sabuj <mir.shahriar@mattermost.com>
@mirshahriar
regenerate openapi manifest
7d157bd
@fmartingr
update manifests
b269a84
gabrieljackson
gabrieljackson approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fmartingr fmartingr mentioned this pull request Feb 1, 2023
Merged
1 task
@fmartingr fmartingr added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Feb 1, 2023
@fmartingr fmartingr merged commit 262f04a into master Feb 1, 2023
@fmartingr fmartingr deleted the feat/MM-49782 branch February 1, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirshahriar mirshahriar mirshahriar approved these changes

@gabrieljackson gabrieljackson gabrieljackson approved these changes

Assignees

@fmartingr fmartingr

Labels
3: Reviews Complete All reviewers have approved the pull request kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmartingr @gabrieljackson @mirshahriar @mm-cloud-bot