Kind version from sha256 instead of tag #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
kind/chore
gabrieljackson
approved these changes
Dec 26, 2022
|
Just re-ran the failed e2e tests and they still failed. Let me know if you need me to re-review this if any fixes need to be made. |
Upgrading the version to |
mirshahriar
approved these changes
Dec 26, 2022
gabrieljackson
approved these changes
Dec 26, 2022
fmartingr
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For security, set the kind version in the
kind.x-k8s.io/v1alpha4/Clusterresource using the sha256 checksum instead of the image tag using two different files for the two architectures the kind team supports (amd64&arm64)Ticket Link
Relates to https://mattermost.atlassian.net/browse/MM-49370
Release Note