-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MΜ 26623] Migrate to single NGINX deployment, enable autoscaling. #263
Conversation
…autoscaling for public Nginx
…nal and external services
… migration downtime
…sterinstallations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the rest lgtm just a small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! It will be nice to have autoscaling and one less utility group to manage.
Other than the one nit I pointed out and Carlos' comment, I am good with this with a few comments that should probably become follow-up tickets for the future. The amount of manual steps involved here is not something we will be able to get away with once we are at scale. As such, I see the following as stuff we may want:
- The ability to re-reconcile installations. If we change the default values of how we deploy something, such as changing an ingress tag, we should have the ability to push that out to all installations somehow, or have a service that can go through them all to ensure they are correct.
- The ability to automatically migrate the correct settings for a utility group. It is probably not worth doing here, but we will eventually have to code out the full migration for updating all the resources associated with upgrades like this. It seems really easy to potentially miss something like updating the ingress on one of the cluster installations once we have more than a handful of these.
I guess I am pointing these things out with the idea that this is a chance to practice doing some amount of the automation above. It will take more time, but is something I think we will have to get used to. I don't think it's a requirement this time, but wanted to point out the opportunity.
Looking for input from the other reviewers on this as well.
Summary
This PR introduces a couple of NGINX changes:
Steps to reprovision existing clusters and to migrate installation to use new NGINX:
cloud cluster provision --cluster <cluster_id> --nginx-version 2.11.0
.helm del --purge public-nginx
helm del --purge private-nginx
Ticket Link
Release Note