Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade lockfile #1251

Merged
merged 1 commit into from
May 18, 2022
Merged

⬆️ Upgrade lockfile #1251

merged 1 commit into from
May 18, 2022

Conversation

afranke
Copy link
Contributor

@afranke afranke commented Feb 3, 2022

This is the result of “just” doing an npm install, which complained that the lockfile version was old and needed to be upgraded, then proceeded to do said upgrade.

Preview: https://pr1251--matrix-org-previews.netlify.app

@thibaultamartin
Copy link
Contributor

Was there anything blocking this PR? Could this impact other projects than the matrix.org website?

@richvdh
Copy link
Member

richvdh commented Apr 21, 2022

I don't think so.

Looks like it just got forgotten about.

But it also looks like it's now outdated.

@afranke
Copy link
Contributor Author

afranke commented Apr 21, 2022

Was there anything blocking this PR?

This didn’t break anything for me, who ran the command, and it didn’t seem to break the CI, but it has potential to break stuff for anyone else who had a clone before, as this changes the lockfileVersion from 1 to 2. When I pushed this, I asked @thibaultamartin to please pull it and see if it broke anything for him, as he was a perfect candidate for someone with an existing clone who might run into problems.

Could this impact other projects than the matrix.org website?

I don’t see how this could affect anything else.

Looks like it just got forgotten about.

Well it’s not as if much work was done on the website since Feb 3rd, apart from content.

But it also looks like it's now outdated.

Yes, if someone has a bit of time to work on the website, a good approach would possibly be to just run npm install again and upgrade as prompted. Otherwise, if we can get the confirmation I asked for above, we could also merge this for now and do a less disruptive update after that.

Signed-off-by: Alexandre Franke <alexandre.franke@matrix.org>
@thibaultamartin thibaultamartin merged commit 9fdf513 into master May 18, 2022
@thibaultamartin thibaultamartin deleted the update-lockfile branch May 18, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants