Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Ensure correct server URLs with .well-known and server type #2547

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Jan 31, 2019

Fixes element-hq/element-web#8346 where the combo of .well-known discovery and switching server types led to a split brain situation where the UI mentioned two different HSes, so you didn't know for sure where you'd actually sign in.

This also flattens the server URLs in the login flow so we don't store so many different kinds (entered vs. discovered). Instead, there's a single place the URLs always flow towards as they change, which should be less confusing.

@jryans jryans requested a review from a team January 31, 2019 18:04
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not immediately obvious to me how all the different URL flags work together, but this does look like the right thing from what I can tell.

@jryans jryans merged commit fb39ba1 into matrix-org:develop Feb 1, 2019
@Cadair
Copy link
Contributor

Cadair commented Feb 1, 2019

I am not a fan of how this means you can't just type your mxid and password into the boxes and not click anything else. The best bit about .well-known for me was there was one set of instructions for users for all possible homeservers. It was "login with your full mxid and password" and Riot will "do the right thing". Now it's dependant upon the homeserver again ☹️

@jryans
Copy link
Collaborator Author

jryans commented Feb 1, 2019

I am not a fan of how this means you can't just type your mxid and password into the boxes and not click anything else. The best bit about .well-known for me was there was one set of instructions for users for all possible homeservers. It was "login with your full mxid and password" and Riot will "do the right thing". Now it's dependant upon the homeserver again ☹️

I am not sure I follow the exact step you dislike here... It's also easily possible there is a bug or oversight.

I think it would help if you file a new issue describing what seems wrong with the new approach in more detail.

@Cadair
Copy link
Contributor

Cadair commented Feb 1, 2019

Thanks @jryans have done 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants