This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
OIDC: test coverage for error cases in Login.tsx
#11073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerryarchibald
added
the
T-Task
artcodespace
approved these changes
Jun 12, 2023
Comment on lines
+287
to
+299
| fetchMock.resetBehavior(); | ||
| fetchMock.get("https://matrix.org/_matrix/client/versions", { | ||
| status: 400, | ||
| }); | ||
| getComponent(); | ||
| await waitForElementToBeRemoved(() => screen.queryAllByLabelText("Loading…")); | ||
|
|
||
| // error displayed | ||
| expect(screen.getByText("Your test-brand is misconfigured")).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it("should reset liveliness error when server config changes", async () => { | ||
| fetchMock.resetBehavior(); |
There was a problem hiding this comment.
Do we need these .resetBehaviours if they're already in the beforeEach hook?
Not familiar with using the package the mocked fetch comes from, so there could be some quirk I'm unaware of here.
There was a problem hiding this comment.
I found them necessary to reset clear the /versions mock that is set in the beforeEach hook
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#25468
Add coverage before making changes in 25468
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.