Include the error object when raising Session.logged_out #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: The `call` argument previously defined in the SDK was never actually populated, and appears to be a documentation error when the definition was copied from `Call.incoming` directly above it.
turt2live
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jul 3, 2019
Fixes element-hq/element-web#10235 CSS and copy are left as an exercise for a later iteration. Login page handling is left for element-hq/element-web#10236 This implementation reuses as much of the Lifecycle flow as it can without causing problems. Most importantly, it requires matrix-org/matrix-js-sdk#975 to be able to detect a soft logout and react to it. When it comes time to starting/stopping the Lifecycle, additional parameters are provided so that the auxiliary services can (re)start themselves without the client starting to sync.
bwindels
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For matrix-org/matrix-react-sdk#3177
Note: The
callargument previously defined in the SDK was never actually populated, and appears to be a documentation error when the definition was copied fromCall.incomingdirectly above it.