Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript declarations #6

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Add TypeScript declarations #6

merged 3 commits into from
Apr 27, 2021

Conversation

decahedron1
Copy link
Contributor

No description provided.

@mathquis
Copy link
Owner

Nice! Thanks :)

Looking at the typings, it seems some options are missing. Can you add them?

  • preEmphasisCoefficient (used by the extractor)
  • vad (used by the detector)

Is it necessary to add something to the package.json file also?

@mathquis mathquis force-pushed the master branch 2 times, most recently from 56cfc9c to fe63b9b Compare April 27, 2021 07:16
@decahedron1
Copy link
Contributor Author

Sorry, added those options now.

I don't believe anything has to be added to the package.json, I'm pretty sure TypeScript is smart enough to automatically find the .d.ts file. Don't quote me on that though.

Also, while I'm here, could you please publish the latest node-gist commit to npm? I'm getting deprecation warnings about node-pre-gyp, seems like you didn't publish 10c0ec4 :)

@mathquis mathquis merged commit 41a4341 into mathquis:master Apr 27, 2021
@mathquis
Copy link
Owner

PR merged. @mathquis/node-gist 1.0.3 released.
Released 1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants