Fix iTunes Search API issues #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial mas-cli#561 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
`desktopSoftware` returns info (including version & description) that aligns with what is displayed earlier in the App Store, while `macSoftware` is at least sometimes out of alignment. Partial mas-cli#561 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Reorder query items for both lookup URLs & search URLs. Partial mas-cli#561 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…mplementation, which allows `lookup` to accept an `Entity` argument instead of being hardcoded to `desktopSoftware`. Resolve mas-cli#561 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are numerous problems with the integration with the iTunes Search API.
Entity.desktopSoftwareinstead ofmacSoftware. Former returns info (including version & description) that aligns with what is displayed in the App Store, while latter is at least sometimes out of alignment. Latter also seems to return any software that can run on a Mac (e.g., iOS, iPadOS, etc. software for Apple Silicon), seeming to default to iOS info. Probably better to get versions for each platform separately so we know what's for what platform.media=softwarequery item to lookup URL to improve results.StoreSearch.lookup(…)&StoreSearch.search(…)to share implementation, which deduplicates code & allows lookup to accept anEntityargument to get an app version for a specific platform instead of being hardcoded todesktopSoftware. Will help allow flags in the future to specify what platforms to check for apps.Resolve #561