🐛 Don't consider an app outdated if the update can't be installed on the current OS

[phatblat]

• Check min OS version
• Test with iOS apps on macOS

Fixes #420

[chris-araman]

👍🏼

[chris-araman]

We can't really test with iOS or iPadOS apps yet, as mas currently only considers Mac apps. We will need to add that testing when we teach mas to install/update/remove iOS and iPadOS apps.

[todo]

Replace string literal with MasStoreSearch.Entity once search branch is merged.

mas/Sources/MasKit/Models/SoftwareProduct.swift

Lines 32 to 37 in 46dda41

	// TODO: Replace string literal with MasStoreSearch.Entity once search branch is merged.
	if let osVersion = Version(tolerant: storeApp.minimumOsVersion), storeApp.kind == "mac-software" {
	let requiredVersion = OperatingSystemVersion(majorVersion: osVersion.major, minorVersion: osVersion.minor,
	patchVersion: osVersion.patch)
	// Don't consider an app outdated if the version in the app store requires a higher OS version.
	guard ProcessInfo.processInfo.isOperatingSystemAtLeast(requiredVersion) else {

---

This comment was generated by todo based on a TODO comment in 46dda41 in #422. cc @mas-cli.

[chris-araman]

/Users/runner/work/mas/mas/Sources/MasKit/Models/SoftwareProduct.swift:32:12: error: Todo Violation: TODOs should be resolved (Replace string literal with Ma...). (todo)

How should we address this? Maybe just fix the issue upon merging into (or rebasing) the search branch?

[phatblat]

Yeah, I wanted to add a reminder for when we add iOS app support, but forgot that the linter flags TODO comments as errors.

[phatblat]

FYI, I tested the "iPhone app installed, changes don't do anything wonky" case but obviously this needs better testing once full support is added for iOS apps.