-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💪🏼 Add arm64_big_sur to bottle script #342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, or maybe in some future work, we could build only arm64
for arm64_*
and only x86_64
for the non-arm64_
OS_VERSIONS
instead of building universal binaries for everything. That seems to be the direction Homebrew decided to take.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved too soon. I think we need the uname -m
change.
I snuck in an OS version check that I've only tested on an Intel Big Sur box. Wanted catalina support so that we can use GitHub Actions runners to build bottles on release until I get an M1 mini for that. |
Only big_sur and catalina allowed
Good idea about building non-universal binaries. That would certainly reduce the size of bottles. Bintray is sunsetting their free package hosting and I'm going to be looking into moving the custom mas tap to GitHub packages but haven't looked to see what sort of space requirements that will need. The current universal bottles are about 4MB each. With 7 platforms (cpu+os) supported that's 21MB per release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I wonder if we could simplify by globbing *
for ${CURRENT_PLATFORM}
.
Made the
bottle
script smarter usinguname -m
andsw_vers -productVersion
to pick betweenarm64_big_sur
,big_sur
andcatalina
.Fixes #333