🐛 Restore AppListFormatter #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-araman
previously approved these changes
Mar 28, 2021
phatblat
force-pushed
the
restore-list-format
branch
2 times, most recently
from
e6d18e9 to
c020fab
Compare
Regressed in 83a1da9
phatblat
force-pushed
the
restore-list-format
branch
from
c020fab to
5fd2876
Compare
chris-araman
approved these changes
Mar 29, 2021
This was referenced Apr 27, 2021
emilazy
added a commit
to emilazy/homebrew-bundle
that referenced
this pull request
Apr 27, 2021
This fixes parsing with the format used after the merge of mas-cli/mas#339: emily@yuyuko ~> mas list 1440147259 AdGuard for Safari (1.9.13) 497799835 Xcode (12.5) 425424353 The Unarchiver (4.3.1) … Before: irb(main):002:0> app.match(/\A(?<id>\d+)\s+(?<name>.*)\s+\((?<version>[\d.]*)\)\Z/) => #<MatchData "1440147259 AdGuard for Safari (1.9.13)" id:"1440147259" name:"AdGuard for Safari " version:"1.9.13"> After: irb(main):003:0> app.match(/\A(?<id>\d+)\s+(?<name>.*?)\s+\((?<version>[\d.]*)\)\Z/) => #<MatchData "1440147259 AdGuard for Safari (1.9.13)" id:"1440147259" name:"AdGuard for Safari" version:"1.9.13">
emilazy
added a commit
to emilazy/homebrew-bundle
that referenced
this pull request
Apr 27, 2021
This fixes parsing with the format used after the merge of mas-cli/mas#339: emily@yuyuko ~> mas list 1440147259 AdGuard for Safari (1.9.13) 497799835 Xcode (12.5) 425424353 The Unarchiver (4.3.1) … Before: irb(main):002:0> app.match(/\A(?<id>\d+)\s+(?<name>.*)\s+\((?<version>[\d.]*)\)\Z/) => #<MatchData "1440147259 AdGuard for Safari (1.9.13)" id:"1440147259" name:"AdGuard for Safari " version:"1.9.13"> After: irb(main):003:0> app.match(/\A(?<id>\d+)\s+(?<name>.*?)\s+\((?<version>[\d.]*)\)\Z/) => #<MatchData "1440147259 AdGuard for Safari (1.9.13)" id:"1440147259" name:"AdGuard for Safari" version:"1.9.13"> Fixes Homebrew#952.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed in 83a1da9 which undid #278. So, it appears that this improvement never made it out in v1.8.0. 😕
Affects #298
Found while reviewing #334