Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

info: Improve error message when argument isn't an integer #480

Closed
1 task done
XVilka opened this issue Nov 2, 2022 · 2 comments
Closed
1 task done

info: Improve error message when argument isn't an integer #480

XVilka opened this issue Nov 2, 2022 · 2 comments
Assignees
@rgoldberg
Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature 🖨 output

Comments

@XVilka
Copy link

XVilka commented Nov 2, 2022

Your Environment

  • mas version: 1.8.6
  • macOS version (system_profiler SPSoftwareDataType -detailLevel mini): 12.6 (ARM64/M1 on MacBook Pro)

mas Install Method

  • brew install mas (homebrew-core)
  • [] mas-cli/tap
  • [] .pkg installer from releases
  • [] Built from source
    • Fork/branch: ? (e.g. mas-cli/main)
    • Xcode version: 10.?

Describe the Bug

Can't show information about installed app

ℤ mas info Pages
Invalid value for 'Argument<Int>(defaultValue: nil, usage: "ID of app to show info", usageParameter: nil)': Pages

To Reproduce

Steps to reproduce the behavior:

  1. mas info <any installed app>
@rgoldberg rgoldberg changed the title 🐛 [BUG] Invalid value for 'Argument<Int>(defaultValue: nil, usage: "ID of app to show info", usageParameter: nil)': on mas info info: Invalid value for 'Argument<Int>(defaultValue: nil, usage: "ID of app to show info", usageParameter: nil)' Sep 14, 2024
@rgoldberg rgoldberg added 🧹 cleanup Optimization of (not bug fix for) an existing feature 🖨 output and removed 🐛 bug labels Sep 14, 2024
@rgoldberg
Copy link
Contributor

mas info only accepts numeric IDs, not names. The error message should be improved.

@rgoldberg rgoldberg changed the title info: Invalid value for 'Argument<Int>(defaultValue: nil, usage: "ID of app to show info", usageParameter: nil)' info: Improve error message when argument isn't an integer Sep 14, 2024
@rgoldberg rgoldberg mentioned this issue Sep 25, 2024
Closed
@rgoldberg rgoldberg self-assigned this Oct 26, 2024
@rgoldberg
Copy link
Contributor

Closing in favor of the more general #533.

About to merge a PR for that.

@rgoldberg rgoldberg closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Dec 30, 2024
@rgoldberg
Replace appNameOrBundleIdentifier & all output appName with `disp…
d7c4526 
…layName`, which provides better fallback values for the app name.

Minor code cleanup.

Resolve mas-cli#480

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg mentioned this issue Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgoldberg rgoldberg

Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature 🖨 output
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XVilka @rgoldberg