Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor house keeping #25

Merged
merged 3 commits into from
Apr 24, 2022
Merged

Conversation

Timmoth
Copy link
Contributor

@Timmoth Timmoth commented Apr 20, 2022

  • Used pattern matching where applicable
  • public -> protected constructor on internal classes
  • Moved HandlerTypeOfExpression out of NotificationMessage inner forloop since Symbol.GetTypeSymbolFullName() seems to be doing quite alot
  • Removed commented out code

@martinothamar
Copy link
Owner

Hey, thanks for this! I've unfortunately just refactored some source generation stuff and I didn't see this until I had already merged... so thats why you have merge conflicts. The files you've cleaned up under /Analysis have gone into the SourceGenerator.Implementation project along with MediatorImplementationGenerator, while the MediatorGenerator has gone into the Roslyn38/Roslyn40 projects.

@Timmoth
Copy link
Contributor Author

Timmoth commented Apr 24, 2022

Hey, thanks for this! I've unfortunately just refactored some source generation stuff and I didn't see this until I had already merged... so thats why you have merge conflicts. The files you've cleaned up under /Analysis have gone into the SourceGenerator.Implementation project along with MediatorImplementationGenerator, while the MediatorGenerator has gone into the Roslyn38/Roslyn40 projects.

Updated!

@martinothamar
Copy link
Owner

Awesome, thanks!

@martinothamar martinothamar merged commit 1442686 into martinothamar:main Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants