Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Seconds display needs both Registry Key and ShortTime changed #31

Closed
corwinx opened this issue Oct 8, 2021 · 2 comments
Closed
Labels
bug Something isn't working ready-to-go Ready to be fixed without further conversation

Comments

@corwinx
Copy link

corwinx commented Oct 8, 2021

Describe the bug

It looks like the if-statement is checking for both the shorttime / timeMode.split to be of a certain length, and the registry key to be set.

Seconds in the clock were not showing up for me even though I had the registry key set, but my shorttime was using AM/PM.
I did some debug printing of the variables through the steps:

showSeconds: 1
dateMode: yyyy-MM-dd
timeMode: h:mm tt
timeMode: %#I:%M %p

timeMode split length: 2
timeMode: %#I:%M %p
dateTimeFormat: %#I:%M %p
%Y-%m-%d

should this not be changed to an OR statement instead of an AND?

so, something along the lines of changing this:
if not("s" in timeMode) and len(timeMode.split(" "))==1 and showSeconds==1:
to
if not("s" in timeMode) and (len(timeMode.split(" "))==1 or showSeconds==1):

@corwinx corwinx added the bug Something isn't working label Oct 8, 2021
@marticliment
Copy link
Owner

Yep, you're right, but it will need a little bit of tweaking to prevent h:mm tt:s happening. I'll fix this soon

@marticliment marticliment added the ready-to-go Ready to be fixed without further conversation label Oct 8, 2021
marticliment added a commit that referenced this issue Oct 8, 2021
@marticliment
Copy link
Owner

The fix will be shipped with version 1.9, but i'm going to add more features before launching v1.9, because this bug has an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-to-go Ready to be fixed without further conversation
Projects
None yet
Development

No branches or pull requests

2 participants