Fix <NumberInput> and <AutocompleteInput> do not forward the event when calling onBlur

[yanchesky]

Fixes #9726

[yanchesky]

Any clues why mobile.cy.js test faills? 🤔 All e2e tests are passing locally (although once mobile.cy.js failed)

[fzaninotto]

I don't know why the mobile e2e tests are failing, you'll have to investigate.

[fzaninotto]

Why don't you use React's built-in FocusEventHandler?

[yanchesky]

I relied on implementation of onBlur function in useInput

react-admin/packages/ra-core/src/form/useInput.ts

Lines 97 to 102 in e87f8f4

	const onBlur = useEvent((...event: any[]) => {
	controllerField.onBlur();
	if (initialOnBlur) {
	initialOnBlur(...event);
	}
	});

and onBlur of InputProps where type is written in such way.

There are also 2 cases where the FocusEventHandler will fail the type contract.

1. A component needs to blur the input (BooleanInput, RichTextInput, FileInput, CheckboxGroupInput) because FocusEventHandler requires event as an argument.

const handleChange = useCallback(
        event => {
            field.onChange(event);
            // Ensure field is considered as touched
            field.onBlur();
        },
        [field]
    );

2. RichTextInput provides EditorEvents['blur'] instead, which doesn't match with the FocusEvent.

Here is the solution I came up that matches type contracts. If you like it i'll commit it

 field: Omit<ControllerRenderProps, 'onBlur'> & {
        onBlur: (
            event?:
                | FocusEvent<HTMLInputElement | HTMLTextAreaElement>
                | EditorEvents['blur']
        ) => void;
    };

[djhi]

Sorry it took so long to answer. Yes, this new type looks fine

[yanchesky]

I don't know why the mobile e2e tests are failing, you'll have to investigate.

yanchesky#1
On my fork, all tests pass, leading me to suspect that this failure is not related to committed changes.

[djhi]

I don't know why the mobile e2e tests are failing, you'll have to investigate.

yanchesky#1 On my fork, all tests pass, leading me to suspect that this failure is not related to committed changes.

All e2e tests pass locally. Probably a random CI failure

[yanchesky]

Are there any other steps I should take in order to finalise this PR?

[djhi]

Are there any other steps I should take in order to finalise this PR?

Can you implement the onBlur type as you suggested in #9730 (comment)? Hopefully that should trigger the CI again. For some Github reason, I can't restart the CI job. Probably because we took to long to react

[slax57]

lgtm

But can you also please fix the conflict with the base branch?
Thanks

[yanchesky]

Instead of adding a new HTMLSpanElement type, I changed the FocusEvent to accept a generic HTMLElement type.

[slax57]

Thanks!