Fix create react admin detect package manager #10534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
create-react-admin
does not detect the package manager used to run it correctly.Solution
Leverage the
process.env.npm_config_user_agent
environment variable to detect it, just likecreate-vite
How To Test
Difficult to test without a release as you have to modify the global cache of the package manager.
$HOME/.bun/install/cache
and the package is unzipped intocreate-react-admin@5.6.0@@@1
$HOME/.yarn/berry/cache
and the package is not unzipped but renamed tocreate-react-admin-npm-5.6.0-941ece3bdb-10c0.zip
Additional Checks
master
for a bugfix, ornext
for a featureAlso, please make sure to read the contributing guidelines.