Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix CI jobs that run on new tag #10525

Merged
merged 1 commit into from
Feb 17, 2025
Merged

[chore] Fix CI jobs that run on new tag #10525

merged 1 commit into from
Feb 17, 2025

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Feb 17, 2025

Problem

#10514 was not enough to run the CI jobs that are supposed to trigger on a new tag.

The issue is that those jobs depend on the e-commerce job, which does not trigger on a new tag.

Solution

Also trigger the e-commerce job on a new tag.

How To Test

We could probably test this with a fake tag, but the change is so simple it can probably wait the next release to be tested.

Additional Checks

  • The PR targets master for a bugfix, or next for a feature

@slax57 slax57 added the RFR Ready For Review label Feb 17, 2025
@djhi djhi merged commit 428c840 into master Feb 17, 2025
2 checks passed
@djhi djhi added this to the 5.6.0 milestone Feb 17, 2025
@djhi djhi deleted the fix-ci-jobs-on-tag branch February 17, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants