[Demo] Fix UI glitches due to multiple conflicting MUI packages #10464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
Jan 23, 2025
| __dirname, | ||
| 'node_modules/@mui/icons-material' | ||
| ), | ||
| }, | ||
| // we need to manually follow the symlinks for local packages to allow deep HMR |
There was a problem hiding this comment.
How about the core MUI packages, which are indirect dependencies ? And how about other major dependencies overridden in the demo package.json (react and react-router)?
There was a problem hiding this comment.
The core MUI packages are resolved from the MUI packages that require them. In our case, the packages from the demo node_modules. I haven't seen multiple react-router packages loaded (neither in vite, nor in the node_modules)
fzaninotto
approved these changes
Jan 23, 2025
fzaninotto
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Following release 5.5, the demo shows larger padding than usual. This is because multiple conflicting versions of MUI packages are loaded. This only happens in the monorepo though.
instead of
Solution
Use Vite aliases to force the resolution of MUI packages to the ones installed in the demo project.
How To Test
Additional Checks
masterfor a bugfix, ornextfor a feature