Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbol size increase #5275

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Fix symbol size increase #5275

merged 4 commits into from
Dec 27, 2024

Conversation

ibesora
Copy link
Collaborator

@ibesora ibesora commented Dec 27, 2024

This PR closes #5090
I haven't been able to create a test that captures the issue because it only appears when looking down from the north pole and I can't get it to happen while running a render test.

Before

Screen.Recording.2024-12-27.at.11.27.59.mov

After

Screen.Recording.2024-12-27.at.11.28.47.mov

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@ibesora ibesora changed the title Ib/fix symbol size Fix symbol size increase Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.81%. Comparing base (9c0ac3e) to head (90a4c9f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5275   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         282      282           
  Lines       38898    38898           
  Branches     6823     6817    -6     
=======================================
  Hits        35714    35714           
  Misses       3056     3056           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibesora ibesora requested a review from HarelM December 27, 2024 12:42
@ibesora ibesora merged commit 3d6d3f4 into maplibre:main Dec 27, 2024
17 checks passed
@HarelM
Copy link
Collaborator

HarelM commented Dec 27, 2024

Any chance you can update the following PR with recent changelog changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images in symbol features with placement other than "point" get scaled when moving the globe around the poles
2 participants