Fix children not retained when wrapped #5271
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5271 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 282 282
Lines 38898 38898
Branches 6819 6823 +4
=======================================
+ Hits 35715 35716 +1
Misses 3055 3055
+ Partials 128 127 -1 ☔ View full report in Codecov by Sentry. |
src/source/source_cache.test.ts
Outdated
| @@ -851,6 +852,43 @@ describe('SourceCache#update', () => { | |||
| sourceCache.onAdd(undefined); | |||
| })); | |||
|
|
|||
| test('retains children tiles for pending parents', () => new Promise<void>(done => { | |||
There was a problem hiding this comment.
Is there a way to avoid "done" in tests? I'm trying to remove usage of those as best as I can, but it's progressing slow, so I want to at least avoid adding more...
There was a problem hiding this comment.
Removed! I just copied what other tests were doing but it seems it's not needed. I've checked that the test passes and fails correctly without it
ibesora
force-pushed
the
ib/fix-children-not-retained
branch
from
985d552 to
6c0807d
Compare
|
Hey @ibesora thanks for the fix, however it seems like similar issue is still reproducible https://codepen.io/kamil-sienkiewicz-asi/pen/zxOZeaP Kapture.2025-01-07.at.11.39.01.webmTake a look at top right part of the visible globe, when im moving camera closer and closer to the north pole, one of the tiles decides to reload(?) which results in blinking cc @HarelM |
This PR fixes #5248
Looking at it, when globe is being used, some tileIDs coordinates are wrapped and we were only using unwrapped tile ids to check if a parent tile had loaded children. The fix here is just to add a check for the canonical key, in addition to the existing one.
Before
Screen.Recording.2024-12-26.at.18.27.33.mov
After
Screen.Recording.2024-12-26.at.18.29.21.mov
Launch Checklist
CHANGELOG.mdunder the## mainsection.