Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve innerHTML handling in code #5057

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Improve innerHTML handling in code #5057

merged 3 commits into from
Nov 18, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Nov 18, 2024

Launch Checklist

Improve code around innerHTML, it should not affect attribution in case everything is OK.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 82.05128% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.17%. Comparing base (b9e001d) to head (9cb8e0c).
Report is 144 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/util/dom.ts 77.41% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5057      +/-   ##
==========================================
+ Coverage   89.07%   89.17%   +0.10%     
==========================================
  Files         269      269              
  Lines       38320    38351      +31     
  Branches     2361     2357       -4     
==========================================
+ Hits        34135    34201      +66     
+ Misses       3190     3149      -41     
- Partials      995     1001       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator Author

HarelM commented Nov 18, 2024

Unfortunately, coverage is not working well, I have manually tested that the relevant places in the code are covered with tests.

@HarelM HarelM merged commit 506090d into main Nov 18, 2024
15 of 17 checks passed
@HarelM HarelM deleted the inner-html-guard branch November 18, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants