Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rollup-plugin-sourcemaps with rollup-plugin-sourcemaps2 #4740

Conversation

birkskyum
Copy link
Member

Closes #4739

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (8ff7d2a) to head (01cc059).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4740      +/-   ##
==========================================
- Coverage   87.90%   87.77%   -0.14%     
==========================================
  Files         247      247              
  Lines       33656    33656              
  Branches     2148     2181      +33     
==========================================
- Hits        29585    29540      -45     
- Misses       3103     3140      +37     
- Partials      968      976       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it does the job.

@birkskyum birkskyum merged commit 718e0cb into maplibre:main Sep 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obsolete rollup-plugin-sourcemap
3 participants