-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename projMatrix to modelViewProjectionMatrix #4215
rename projMatrix to modelViewProjectionMatrix #4215
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4215 +/- ##
==========================================
- Coverage 87.75% 87.43% -0.33%
==========================================
Files 242 242
Lines 33081 33081
Branches 2332 2182 -150
==========================================
- Hits 29030 28923 -107
- Misses 3083 3149 +66
- Partials 968 1009 +41 ☔ View full report in Codecov by Sentry. |
Do we consider this change a breaking change? |
I didn't consider it breaking of the public API (which is usually what we mean by breaking), since transform is internal and excluded from docs etc. Added an entry to the changelog now. |
as mentioned in here, the projMatrix is actually a modelViewProjectionMatrix, and it unfortunately overloads and causes confusion about the otherwise well-defined term "projection matrix". This naming is a bit more explicit / strict, which i think we need to communicate clearly.
Launch Checklist
CHANGELOG.md
under the## main
section.