-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update link from logo from Mapbox to MapLibre #151
Conversation
As discussed in #121 (comment) and brought up in EqualStreetNames/equalstreetnames#191
Duplicate of #150 😄 |
Let's work with the earlier one then 😄 |
Thanks anyway :) |
Sorry, I did not see the updated docs comment. Let's see if this works better than before. |
Bundle size report: Size Change: +11 B
ℹ️ View DetailsNo major changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've closed my PR #150 since this one is more complete (update of the docblock).
I would use https://maplibre.org/ instead of https://www.maplibre.org/ though.
Use URL without www. Co-authored-by: Jonathan Beliën <jbelien@users.noreply.github.com>
Fully agree, I've updated the PR accordingly |
I'm not sure about the change in CHANGELOG.md, do I do that directly in the file or in the first comment on this PR? |
Also I don't seem to be able to apply a label here on GitHub... |
Also got confused about that one 😄 |
Edit the changelog file in your branch with a line ending with the pull request reference |
Labels are only available to members of the development team, which maybe you can be in the future :) |
Looks good to me. Thanks for contributing to both of you! |
As discussed in #121 (comment) and brought up in EqualStreetNames/equalstreetnames#191
I found out that the link in the bottom left (from the MapLibre logo) goes to Mapbox.com, but probably should not.
This PR aims to correct that, and also changes the help text of the function a bit.
Launch Checklist
maplibre-gl-js
changelog:<changelog></changelog>