Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link from logo from Mapbox to MapLibre #151

Merged
merged 3 commits into from
May 4, 2021
Merged

Update link from logo from Mapbox to MapLibre #151

merged 3 commits into from
May 4, 2021

Conversation

habi
Copy link
Contributor

@habi habi commented May 3, 2021

As discussed in #121 (comment) and brought up in EqualStreetNames/equalstreetnames#191

I found out that the link in the bottom left (from the MapLibre logo) goes to Mapbox.com, but probably should not.
This PR aims to correct that, and also changes the help text of the function a bit.

Launch Checklist

  • confirm your changes do not include backports from Mapbox projects (unless with compliant license)
  • briefly describe the changes in this PR
  • add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'

@habi habi mentioned this pull request May 3, 2021
9 tasks
@jbelien
Copy link
Contributor

jbelien commented May 3, 2021

Duplicate of #150 😄

@wipfli
Copy link
Contributor

wipfli commented May 3, 2021

Let's work with the earlier one then 😄

@wipfli wipfli closed this May 3, 2021
@wipfli
Copy link
Contributor

wipfli commented May 3, 2021

Thanks anyway :)

@wipfli wipfli reopened this May 3, 2021
@wipfli
Copy link
Contributor

wipfli commented May 3, 2021

Sorry, I did not see the updated docs comment. Let's see if this works better than before.

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

Bundle size report:

Size Change: +11 B
Total Size Before: 205 kB
Total Size After: 205 kB

Output file Before After Change
maplibre-gl.js 196 kB 196 kB +11 B
maplibre-gl.css 8.87 kB 8.87 kB 0 B
ℹ️ View Details No major changes

Copy link
Contributor

@jbelien jbelien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've closed my PR #150 since this one is more complete (update of the docblock).

I would use https://maplibre.org/ instead of https://www.maplibre.org/ though.

src/ui/control/logo_control.js Outdated Show resolved Hide resolved
Use URL without www.

Co-authored-by: Jonathan Beliën <jbelien@users.noreply.github.com>
@habi
Copy link
Contributor Author

habi commented May 3, 2021

I would use https://maplibre.org/ instead of https://www.maplibre.org/ though.

Fully agree, I've updated the PR accordingly

@habi
Copy link
Contributor Author

habi commented May 3, 2021

I'm not sure about the change in CHANGELOG.md, do I do that directly in the file or in the first comment on this PR?

@habi
Copy link
Contributor Author

habi commented May 3, 2021

Also I don't seem to be able to apply a label here on GitHub...

@jbelien
Copy link
Contributor

jbelien commented May 3, 2021

I'm not sure about the change in CHANGELOG.md, do I do that directly in the file or in the first comment on this PR?

Also got confused about that one 😄

@wipfli
Copy link
Contributor

wipfli commented May 3, 2021

Edit the changelog file in your branch with a line ending with the pull request reference (#151). Then commit and push to your repo.

@wipfli
Copy link
Contributor

wipfli commented May 3, 2021

Labels are only available to members of the development team, which maybe you can be in the future :)

@wipfli
Copy link
Contributor

wipfli commented May 3, 2021

Looks good to me. Thanks for contributing to both of you!

@wipfli wipfli merged commit 006278d into maplibre:main May 4, 2021
@habi habi deleted the patch-1 branch May 26, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants