fix missing of errorHandler #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
reviewed
Jan 21, 2019
MapboxGeocoder/MBGeocoder.swift
Outdated
| @@ -268,7 +268,10 @@ open class Geocoder: NSObject { | |||
| request.setValue(userAgent, forHTTPHeaderField: "User-Agent") | |||
| return URLSession.shared.dataTask(with: request) { (data, response, error) in | |||
|
|
|||
| guard let data = data else { return } | |||
| guard let data = data else { | |||
| errorHandler(error) | |||
There was a problem hiding this comment.
Great catch. Would you mind adding a test for this case? Also, you have to return the error as? NSError
There was a problem hiding this comment.
got it, i will try this later today.
There was a problem hiding this comment.
I see 51300ab refers to a test case, but I don't see one. Is this still something you could add?
Thanks for the PR, this is important missing functionality.
|
@frederoni will you please review this pr once again? |
frederoni
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case that the data task fails, the geocoder still need to call back with errorHandler, otherwise the caller may not complete.
Fixes #170.