Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix #23

Merged
merged 2 commits into from
May 9, 2019
Merged

Quick fix #23

merged 2 commits into from
May 9, 2019

Conversation

plammens
Copy link
Contributor

@plammens plammens commented May 7, 2019

Quick improvement left out at #22 . Now the _CONVERSIONS dict uses actual enum members instead of values. Simplified getting the correct enum member inside the haversine function based on the built-in programmatic acces of the enum (enum.__call__).

Renamed Units to Unit along the way, to comply with conventions. Now the following more informative error is raised upon using an invalid unit, without any additional exception handling:

haversine(a, b, unit='spam')
ValueError: spam is not a valid Unit

@plammens plammens mentioned this pull request May 7, 2019
Merged
@plammens plammens changed the title Fix22 Quick fix May 7, 2019
@plammens
Copy link
Contributor Author

plammens commented May 7, 2019 •
edited
Loading

Seems there is something wrong with the Pipfile.lock of 0ff1e3a and the Travis CI checks

@jdeniau jdeniau merged commit eaa97c3 into mapado:master May 9, 2019
@jdeniau
Copy link
Member

jdeniau commented May 9, 2019

👍

@jdeniau
Copy link
Member

jdeniau commented May 9, 2019

Released as 2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plammens @jdeniau