Support custom schema extensions for users and groups #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
force-pushed
the
f/schema-extensions
branch
from
779a7dd to
b86950e
Compare
manicminer
changed the title
|
This looks great, looking forward to using this in my project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for schema extension data for Groups and Users
Marshaling of schema extension data is handled automatically by the Group and User structs, enabling use of the existing
Update()methods on the respective clients.Unmarshaling is handled by either the provided
msgraph.SchemaExtensionMaptype, or a custom type supplied by the caller. Such a custom type must have an explicitUnmarshalJSON()method to satisfy theSchemaExtensionPropertiesinterface. Both approaches are tested in theTestSchemaExtensionsClient()test.