Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for directory role #30

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

michaljirman
Copy link
Contributor

@michaljirman michaljirman commented Apr 13, 2021

@manicminer thanks for merging the PR regarding the directory role templates. The next model which makes sense for me to add support for are the directory roles.

This PR adds basic support for the following operation on the directory role object:

  • listing activated directory roles within a tenant; only activated directory roles are available for listing/retrieving. A separate PR will follow adding support to activate the directory role template within a tenant.
  • retrieving a directory role by id
  • listing, retrieving and updating members of a directory role

Notes:

  • API for the directory roles do not support PATCH so updating members in batches is not possible afaiu
  • Groups model was updated with an IsAssignableToRole attribute available only in the MS Graph Beta API. Groups client is already using beta API so there was no need for change. This attribute can be set only on the group's creation. It is also required to be set for directory role assignment. This operation is part of the tests.
  • Directory role assignments require at least P1 Azure AD Premium level

@michaljirman michaljirman marked this pull request as ready for review April 13, 2021 18:41
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaljirman Many thanks for this contribution. This LGTM and tests are working on my end 👍

@manicminer manicminer added this to the v0.12.0 milestone Apr 13, 2021
@manicminer manicminer added enhancement New feature or request tests Includes tests labels Apr 13, 2021
@manicminer manicminer merged commit aa88cc4 into manicminer:main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Includes tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants