-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for B2CUserFlow CRUD operations #179
Conversation
This commit adds the following - B2CUserFlowClient for interacting with /identity/b2cuserflow endpoint - B2CUserFlow model for the request/response payload - Some tests for the CRUD operations
UNKNOWNFUTUREVALUE_USERFLOWTYPE | ||
) | ||
|
||
type B2CUserFlow struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
B2cUserFlow has a bunch of fields https://learn.microsoft.com/en-us/graph/api/resources/b2cidentityuserflow?view=graph-rest-beta . I've added only the minimal ones.
I can add more fields if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will want to add these in time, but I'm happy to merge with these fields for now.
Hello @manicminer 👋 ! Can you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jarifibrahim Thanks for this contribution! This mostly LGTM, it just looks like an errant file made it into the commit history. If you can fix that then this should be good to merge.
UNKNOWNFUTUREVALUE_USERFLOWTYPE | ||
) | ||
|
||
type B2CUserFlow struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will want to add these in time, but I'm happy to merge with these fields for now.
Related to hashicorp/terraform-provider-azuread#175
This commit adds the following