-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement multiple languages support for the TermsOfServices #552
Conversation
@martinRenou for the linter, you can run |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @martinRenou! Looks good.
I'm thinking that maybe we should modify the GET api/tos
end-point to receive the language as a parameter.
Codecov Report
@@ Coverage Diff @@
## main #552 +/- ##
==========================================
- Coverage 82.79% 81.97% -0.82%
==========================================
Files 78 78
Lines 5964 5971 +7
==========================================
- Hits 4938 4895 -43
- Misses 1026 1076 +50
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @martinRenou!
Taking over #543 and making some changes in the original implementation.