Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multiple languages support for the TermsOfServices #552

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

martinRenou
Copy link
Member

Taking over #543 and making some changes in the original implementation.

@wolfv
Copy link
Member

wolfv commented Jul 27, 2022

@martinRenou for the linter, you can run pre-commit run --all

@martinRenou
Copy link
Member Author

Thanks!

Copy link
Collaborator

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @martinRenou! Looks good.
I'm thinking that maybe we should modify the GET api/tos end-point to receive the language as a parameter.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #552 (5bdf23f) into main (1d2feb9) will decrease coverage by 0.81%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   82.79%   81.97%   -0.82%     
==========================================
  Files          78       78              
  Lines        5964     5971       +7     
==========================================
- Hits         4938     4895      -43     
- Misses       1026     1076      +50     
Impacted Files Coverage Δ
quetz/tasks/indexing.py 93.42% <100.00%> (+2.20%) ⬆️
quetz/pkgstores.py 42.45% <0.00%> (-11.60%) ⬇️
quetz/main.py 86.16% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2feb9...5bdf23f. Read the comment docs.

Copy link
Collaborator

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @martinRenou!

@hbcarlos hbcarlos merged commit bee4a48 into mamba-org:main Jul 28, 2022
@martinRenou martinRenou deleted the tos_lang branch July 28, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants