-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for #103: Simple handling of local (file://) urls #117
Conversation
Thanks for your work! I see this PR is marked as a draft, so I won't look at the code yet. But to address your questions:
That sounds good to me, I would like plain text support to be added. If that heuristic you mention ends up being too complicated or intensive, that just looking for *.txt is good with me too.
Normal gemini sites aren't required to show directory listings, but most servers will if an
Linking to relative files can be fixed by creating a
This should fix linking to local files. |
Thanks for taking the time to investigate! Yeah I wanted to ventilate alternatives before continuing. Will give it a shot as discussed
|
Thanks! Please mark this as not-WIP when you're done and make a comment so I get notified. |
@makeworld-the-better-one ok, tested on Windows as well as Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding this! It's a great feature to have. Please see my comments below.
Also, it would be helpful to test with directories and files with Unicode characters in them. Please also test the directory view with those.
Yes, also works with utf8 filenames and directories, just tested with my national åäö's, and also various wonky faces and symbols 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR! It's almost ready, there's just one bug left, and some cosmetic changes.
Simple implementation for rendering local (file://) documents.
When opening a
file://
url:If it is a directory:
Render a page with links to all dirs and files in directory.
Links are made to all kinds of files, checking if reasonable to open is done when actually opening them (with error popups)
If it is a file:
TODO
fixes #103