Properly compare versions equal or over to 1.15 in TestMustGetParsedD… #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration Fix magiconair#52 Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
|
Where did you see that the minimum version is go1.13? I've fixed the tests so that it also works for go1.14...go1.3 again. Kind of a pride thing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uration
Fix #52
Signed-off-by: Robert-André Mauchin zebob.m@gmail.com
I have tested this with Go 1.14 and Go 1.16. It won't work over Go 1.99 and Go 2.x, and not below 1.10, but since the minimun required version is go 1.13, I don't think this is an issue.