send JinjaTemplateVars through to template on config file load always. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinjaTemplateVars were only being sent through if calling `render_template_from_path` not if calling `render_template` directly. the `load_jsonlike` functions used `render_template` because the loaded the config file into a str and then rendered. So they didn't get the jinja template vars.
…ig by default, to prevent yaml dump writing out python class dumping if possible
Codecov Report
@@ Coverage Diff @@
## develop #159 +/- ##
===========================================
+ Coverage 81.57% 81.59% +0.01%
===========================================
Files 29 29
Lines 2225 2238 +13
Branches 417 419 +2
===========================================
+ Hits 1815 1826 +11
- Misses 269 270 +1
- Partials 141 142 +1
|
madeline-scyphers
deleted the
bugfix/fix-jinja-env-vars-not-being-templated-right
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JinjaTemplateVars were only being sent through if calling
render_template_from_pathnot if callingrender_templatedirectly. theload_jsonlikefunctions usedrender_templatebecause the loaded the config file into a str and then rendered. So they didn't get the jinja template vars.