fix(lib): use precise capturing on 1.82+

[indietyp]

Fixes #434 by conditionally adding + use<'s> to the implementation of the callback, but only if on 1.82+

Additionally it adds tests for the MSRV and 1.82 to the CI.

[jeertmans]

Looks great, thanks for being so quick!

Please take a look at my comments.

[jeertmans]

As indicated by the CI, I think the new build dependency requires us to bump the MSRV to 1.74

[indietyp]

I don't think this is actually caused by the new build-dependency (it only has semver as a dependency) I think the issue exists because the toolchain was never before tested (see the {{matrix.rust}} addition). I think this might be a problem with rstest.

[indietyp]

actually correction, looking at the output of cargo tree --workspace the issue is logos-cli:

logos/logos-cli/Cargo.toml

Line 11 in 491842d

predicates = "2.1.1"

[jeertmans]

I don't think this is actually caused by the new build-dependency (it only has semver as a dependency) I think the issue exists because the toolchain was never before tested (see the {{matrix.rust}} addition). I think this might be a problem with rstest.

I see, but I don't get why the msrv_check workflow didn't catch this before...

actually correction, looking at the output of cargo tree --workspace the issue is logos-cli:

logos/logos-cli/Cargo.toml

Line 11 in 491842d

predicates = "2.1.1"

You are right, I was too quick on my conclusions :-)

[indietyp]

We could either raise the MSRV to 1.74, raise the CI to only test 1.74 or downgrade predicates to something that supports 1.70

[jeertmans]

We could either raise the MSRV to 1.74, raise the CI to only test 1.74 or downgrade predicates to something that supports 1.70

I think the issue is actually the CI doesn't use --locked, so this is probably why the issue wasn't discovered before.

For the sake of simplicity, we can just bump to 1.74 here.

[jeertmans]

I think you need to also update this field

[jeertmans]

Looks all good @indietyp, thanks!