-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add Standard Dependapot Workflows and Contribution notes #562
ci: Add Standard Dependapot Workflows and Contribution notes #562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good with some small nits, and need an update to package.json.
Did you copy these from web core sdk/higgs shop? I noticed that those use quotes, and the spacing is different across them all (some are 4, some are 2). This is fine, but we should make a sustained engineering ticket to pick one and be consistent across them all. I'd suggest we look at mparticle-workflows
and stick to whatever format that uses.
@@ -0,0 +1,154 @@ | |||
name: Release Web Media SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package.json is missing the semantic release packages. Please include them all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Kudos, SonarCloud Quality Gate passed!
|
Instructions
development
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)