Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Standard Dependapot Workflows and Contribution notes #562

Merged
merged 7 commits into from
Mar 27, 2023

Conversation

alexs-mparticle
Copy link
Contributor

@alexs-mparticle alexs-mparticle commented Mar 24, 2023

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: /~https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: /~https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Apply standard Pull Request and Release Actions
  • Create Contribution.md file
  • Remove references to Travis
  • Note: This project was created using Node 14, which is very out-of-date. As such, the package-lock.json file needs to be manually updated to a more modern version of node. We will be addressing this in a future update: https://go.mparticle.com/work/SQDSDKS-5236

Testing Plan

  • Was this tested locally? If not, explain why.
  • N/A as this related to CI/CD pipeline

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good with some small nits, and need an update to package.json.

Did you copy these from web core sdk/higgs shop? I noticed that those use quotes, and the spacing is different across them all (some are 4, some are 2). This is fine, but we should make a sustained engineering ticket to pick one and be consistent across them all. I'd suggest we look at mparticle-workflows and stick to whatever format that uses.

@@ -0,0 +1,154 @@
name: Release Web Media SDK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json is missing the semantic release packages. Please include them all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexs-mparticle alexs-mparticle merged commit 9a2f6fa into development Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants