Fix build system to work on Red Hat-based systems #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak the curl-impersonate build system to make it work on Red Hat based systems such as CentOS, Fedora and Amazon Linux. * Change the Makefile to be more portable with different bash versions. * Detect whether cmake is 'cmake' or 'cmake3', and whether ninja is 'ninja' or 'ninja-build'. * Explicitly tell brotli to put its libraries in 'lib' dir, otherwise it might put them in 'lib64' where curl doesn't find them. * Add instructions for building curl-impersonate from source on Red Hat based systems.
* Add compiler flags to the boringssl build step to suppress gcc errors raised when compiling with gcc 12+, which is present in Fedora. It is not clear whether this is a compiler bug or a boringssl bug, however the errors only appear when building in release mode and with gcc 12, so I don't see any problem with manually supressing them. * Add documentation for building on Fedora.
|
Solves #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the curl-impersonate build system to make it work on Red Hat
based systems such as CentOS, Fedora and Amazon Linux.
'ninja' or 'ninja-build'.
might put them in 'lib64' where curl doesn't find them.
based systems.