Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-IDE Support and more Run-Configurations #88

Merged
merged 23 commits into from
Sep 7, 2023

Conversation

Kroko-fant
Copy link
Contributor

@Kroko-fant Kroko-fant commented Jun 22, 2023

Motivation and Context

In recent years most ArtemisProjects use Gradle over Maven for Java Run Configurations. However Artemis has only supported Maven so far. Furthermore the User has gotten warnings about unsupported Programming Languages that appeared in a way suggesting orion threw an error.

Description

  • Gradle Support for Testing (Tutor)
  • Orion differentiates between Gradle and Maven Projects for Java programs
  • Removed Warnings for the User that Languages apart from Java aren't supported
  • Added detect SDK for Kotlin

Steps for Testing

  1. Install the release as described in the readme
  2. Open an exercise in Orion
  3. ...

Review Progress

Code Review

  • Review 1
  • Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

updated dependencies
updated kotlin version
fixed a change in the API of Jetbrains
# Conflicts:
#	build.gradle.kts
Removed unnecessary comment
fixed some spelling/grammar stuff
fixed project StartupActivity to use the new version ProjectActivity
# Conflicts:
#	build.gradle.kts
#	src/main/java/de/tum/www1/orion/settings/OrionSettingsProvider.java
#	src/main/java/de/tum/www1/orion/ui/settings/OrionPluginSettings.kt
#	src/main/resources/META-INF/plugin.xml
# Conflicts:
#	src/main/java/de/tum/www1/orion/settings/OrionSettingsProvider.java
#	src/main/resources/META-INF/plugin.xml
Made Run Configurations Optional instead of throwing an error
Checks if IDE is intelliJ for Java Runconfigurations
@Kroko-fant Kroko-fant changed the title Run configurations Multi-IDE Support and more Run-Configurations Jun 22, 2023
@Kroko-fant Kroko-fant marked this pull request as ready for review July 6, 2023 19:25
Copy link

@MaximilianAnzinger MaximilianAnzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual

Copy link

@lennart-keller lennart-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session

Copy link

@basak-akan basak-akan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested during testing session

@krusche krusche merged commit 9e0a8db into ls1intum:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants