Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Delete trailing slashes #76

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

MDK5
Copy link
Contributor

@MDK5 MDK5 commented Nov 18, 2021

Motivation, Context and Description

Fixes #75. Originally I settled with a highlighted note in Orion's documentation, but as pointed out this is not immediately obvious to new users. Since I failed to find a generic approach to parse the url and generate a normalized form using the java library, this PR now just bluntly removes any trailing slash, solving the issue at hand, but leaving other, similar issues with urls written in other formats as is.

Also removes a document listener setting a variable that was never read, presumably a leftover from a previous refactoring

Steps for Testing

  1. Install the release as described in the readme.
  2. Configure a URL with a trailing slash as Artemis Base URL.
  3. Bear in mind only adding the slash will not change the stored value and therefore not trigger a reload.
  4. All pages should still load normally.

@MDK5 MDK5 self-assigned this Nov 18, 2021
Copy link

@lschlesinger lschlesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with different working and breaking URLs, works as expected.

Copy link

@willergeorg willergeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested during testing session. Functionality works for me.

Copy link

@Malyuk-A Malyuk-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested during testing session on local Orion version. Works great and code looks good

@krusche krusche merged commit fbf2693 into master Nov 19, 2021
@krusche krusche deleted the enhancement/filter-trailing-slash branch November 19, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in exercise view if Artemis base URL ends with "/"
5 participants