fix: remane LBModeNotDefault to LBModeDefault #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrekkieCoder
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @nik-netlox @TrekkieCoder
This pull request includes changes to the load balancer mode handling in the
pkg/agent/manager/loadbalancerpackage. The main changes involve renaming and correcting the load balancer mode constants to ensure the default mode is set correctly.Changes to load balancer mode handling:
pkg/agent/manager/loadbalancer/loadbalancer.go: Corrected the load balancer mode assignment by changingLBModeNotDefaulttoLBModeDefaultin theaddLoadBalancermethod.pkg/api/lb.go: Renamed theLBModeNotDefaultconstant toLBModeDefaultto reflect the correct load balancer mode.